Problem with Interaction Filtering when working with V4 pacts

[jakubbrodzinski]

Hi,
I think I've stumbled upon subtle issue regarding Interaction Filtering in pact-jvm, and I would much appreciate someone taking a look at it and confirming whether it is an issue or just misconfiguration on my side.

• Provider perspective:
  Once we migrated to pact-jvm 4.5.0, we started publishing pacts with pactSpecification.version == 4.0
• Consumer perspective:
  Once the provider switched to the new version, we cannot verify the latest pacts and we are getting an error:

Source: Pact Broker (...) consumerVersionSelectors=[Selector(tag=dummy-tag, latest=true, consumer=null, fallbackTag=)]
au.com.dius.pact.provider.junitsupport.loader.NoPactsFoundException: No Pact files were found to verify

• Potential root cause:
  • As it turns out, we actually are able to locate the latest pacts, but they are getting filter out by @PactFilter(value = "/interaction/path", filter = InteractionFilter.ByRequestPath.class).
  • In the filter mentioned above, we check whether condition interaction instanceof RequestResponseInteraction is true, and it works just fine for V3. Sadly for V4, what we are getting there is a class of type SynchronousHttp which extends both V4Interaction and SynchronousRequestResponse, but no RequestResponseInteraction.
  • I think by replacing the instanceof statement with interaction.isSynchronousRequestResponse() we could make it more flexible and resilient to type structure changes. The implementation would look like this:

               if (interaction.isSynchronousRequestResponse()) {
                   var requestPath = interaction.asSynchronousRequestResponse().getRequest().getPath();
                   return Arrays.stream(values).anyMatch(requestPath::matches);
               } else {
                   return false;
               }

What do you think? Thanks in advance! :)

[jakubbrodzinski]

I've stumbled upon one more thing. Was the change from:

map["headers"] = request.headers.entries.associate { (key, value) -> key to value.joinToString(COMMA) }

to

map["headers"] = headers (headers is of type MutableMap<String, List<String>>)

between V3 and V4 pacts done intentionally? As of now, users using pact-jvm < 4.50 are unable to verify Pacts published by consumers with pact-jvm >= 4.5.0. I've gone through RFC, and the change to Headers was not mentioned there.

[github-actions]

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-808). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

[rholshausen]

As to the headers, the code to join it into a string was a bug, as the V3 spec changed it to use Map<String, List<String>> format. The V4 models were corrected, but I see the original bug is still there (I thought it had been updated).

But they should support both formats of headers. If you are unable to verify Pacts with that format, can you raise an issue with details of the errors?