Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading au.com.dius.pact.provider:junit5 from 4.3.15 to 4.3.16 results in compilation failure #1630

Closed
gertjanschouten opened this issue Oct 28, 2022 · 3 comments

Comments

@gertjanschouten
Copy link

gertjanschouten commented Oct 28, 2022

Hello!

We have unit tests annotated with @Provider. We never used to specify a value, because we have all our Pact config in the pom.xml (in this case the "pact.provider.name" property). Since 4.3.16, the @Provider annotation requires a value, breaking all of our Provider tests.

The expected behaviour is that @Provider without a value automatically picks up "pact.provider.name", without you having to specify this and that the value of @Provider is not mandatory.

Thanks!

@gertjanschouten
Copy link
Author

Perhaps a default value of "${pact.provider.name}" would result in the desired behaviour?

@rholshausen
Copy link
Contributor

/jira create

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

👋 Thanks, Jira [PACT-466] ticket created.

rholshausen added a commit that referenced this issue Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants