Regression: No ParameterResolver registered for org.apache.http.HttpRequest

[knutwannheden]

We are currently testing the new 4.3.0 release and discovered a regression in the JUnit 5 integration: There is no longer a ParameterResolver registered for the org.apache.http.HttpRequest type. Thus a test method can no longer declare a HttpRequest parameter as described in the documentation:

    @TestTemplate
    @ExtendWith(PactVerificationInvocationContextProvider.class)
    void testTemplate(PactVerificationContext context, HttpRequest request) {
      // This will add a header to the request
      request.addHeader("X-Auth-Token", "1234");
      context.verifyInteraction();
    }

Looking at the history it looks like this would work if the parameter were declared as of type ClassicHttpRequest, but this is a subtype of HttpRequest and I assume this was refactored by accident.

[uglyog]

With 4.3.0 the Apache HTTP client has been upgraded to 5, which has different interfaces and classes. HttpRequest is now an interface that does not have any methods to get the request/response bodies. ClassicHttpRequest provides the same interface as the previous version.

But as you probably only need to use it to set headers, supporting it makes sense.

[uglyog]

Just a note that the new interface is now org.apache.hc.core5.http.HttpRequest not org.apache.http.HttpRequest

[knutwannheden]

I see. Thanks for the feedback. So possibly all that is needed is a documentation update and a migration guide.

[uglyog]

Migration doc is there already https://github.com/pact-foundation/pact-jvm/blob/master/upgrade-to-4.3.x.md, I'll update the docs.

[uglyog]

4.3.1 released which will allow you to use HttpRequest

[knutwannheden]

Thanks!