Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publishing pacts with branches #1453

Closed
bethesque opened this issue Sep 29, 2021 · 3 comments
Closed

Add support for publishing pacts with branches #1453

bethesque opened this issue Sep 29, 2021 · 3 comments

Comments

@bethesque
Copy link
Member

  • Add user facing option to pact publishing interfaces to support a "branch" property
  • Call the Broker API to set the branch for the version in one of the following ways:
    • Quick and dirty hack - add yet another separate HTTP call to the pact publishing code to create the branch version.
    • The "slightly more work but better in the longer term" solution - use the new "all in one" pact publishing endpoint.

Docs for the quick and dirty solution

  • Before creating the tags, send a PUT using the pb:pacticipant-branch-version relation from the index with params pacticipant, branch and version.
  • If the branch is set, and the broker does not support branches (ie. the relations are not there), raise an appropriate error (or print warning - which ever works best for JVM) indicating that the broker does not support branches, and they should update to Pact Broker version 2.86.0 or later for branch support.

Docs for the long term solution

See #1452

@johnreilly100
Copy link

johnreilly100 commented Jan 10, 2022

Just to be clear as it stands is there no way to set the branch though the JVM 4.3.x library? Asked the same question in #1501

@uglyog
Copy link
Member

uglyog commented Jan 10, 2022

It hasn't been implemented yet

@uglyog
Copy link
Member

uglyog commented Jan 12, 2022

Released 4.3.4/4.2.19/4.1.33

@uglyog uglyog closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants