Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output while running provider verification test #1449

Closed
danilchican opened this issue Sep 27, 2021 · 0 comments
Closed

Wrong output while running provider verification test #1449

danilchican opened this issue Sep 27, 2021 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@danilchican
Copy link

danilchican commented Sep 27, 2021

Pact Broker java version used: au.com.dius.pact.provider:junit5:4.2.13

While passing the property pactbroker.url instead of deprecated(host,scheme,port) I have the wrong output in logs (tests report):

Pact Broker http://null  ......

The problem is in PactSource.kt -> PactBrokerSource constructor -> :

where I : Interaction {
  override fun description() =
    if (port == null) {
      "Pact Broker $scheme://$host"
    } else {
      "Pact Broker $scheme://$host:$port"
    }
}

Here you still using old(deprecated) properties. And if you pass new one, you have wrong output.
It's a minor bug.

@danilchican danilchican changed the title Filtering consumers with WIP enabled will retrieve not requested Consumer's WIP pacts. Wrong output while running provider verification test Sep 27, 2021
@uglyog uglyog added the bug Indicates an unexpected problem or unintended behavior label Sep 28, 2021
uglyog pushed a commit that referenced this issue Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants