Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore option for pact-jvm can-i-deploy #1444

Closed
bawoodruff opened this issue Sep 20, 2021 · 4 comments
Closed

add ignore option for pact-jvm can-i-deploy #1444

bawoodruff opened this issue Sep 20, 2021 · 4 comments

Comments

@bawoodruff
Copy link
Contributor

The pact-broker CLI offers this ignore option -- I would like to filter providers through a similar mechanism with the pact-jvm maven plugin:

      [--ignore=IGNORE]                    
              # The pacticipant name to ignore. Use once for each pacticipant
                being ignored. A specific version can be ignored by also
                specifying a --version after the pacticipant name option.
@uglyog
Copy link
Member

uglyog commented Sep 27, 2021

I've added the ignore options, but I'm unsure how Maven will map system properties to a repeated Mojo parameter. I assume it will be something like -Dignore.name=one -Dignore.version=123 -Dignore.name=two. You'll need to play around with them to work that out.

@uglyog
Copy link
Member

uglyog commented Sep 27, 2021

No, that doesn't work

@uglyog
Copy link
Member

uglyog commented Sep 27, 2021

Maven only supports comma separated values for system properties mapped to collections. I managed to get pact:can-i-deploy -Dpacticipant='Animal Profile Service' -Dlatest=true -Dignore=bob:100,fred to set ignore = [IgnoreSelector(name=bob, version=100), IgnoreSelector(name=fred, version=null)]

I'll update the docs with the format required for that parameter.

@uglyog
Copy link
Member

uglyog commented Sep 27, 2021

4.1.28/4.2.13 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants