Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow {variable} vs ${variable} specifier in parameterized paths #1410

Closed
bawoodruff opened this issue Aug 1, 2021 · 2 comments
Closed

Allow {variable} vs ${variable} specifier in parameterized paths #1410

bawoodruff opened this issue Aug 1, 2021 · 2 comments

Comments

@bawoodruff
Copy link
Contributor

bawoodruff commented Aug 1, 2021 •
edited
Loading

I'd like to be able to share URI specifications between Pact and RestTemplate -- but parameterized paths in Pact JVM are using ${variable} whereas Spring's RestTemplate use {variable} in the path specification.

I am currently performing a workaround as such:

 .pathFromProviderState(
    StoreManagement.UriComponents.GET_STORE_BY_RELATIVE_STORE_URL.replace("{", "${"),
    StoreManagement.UriComponents.GET_STORE_BY_RELATIVE_STORE_URL.replace("{relativeStoreUrl}", ValidStoreUrl))

Can we have an option to change the specifier in Pact JVM?
uglyog pushed a commit that referenced this issue Aug 15, 2021
feat: allow the expression markers in expressions to be overridden #1410
e84e19c
uglyog pushed a commit that referenced this issue Aug 15, 2021
chore: update readmes with expression marker overrides #1410
4b84e68
uglyog pushed a commit that referenced this issue Aug 15, 2021
feat: restrict expression marker overrides to provider state expressi…
837a801 
…ons #1410
uglyog pushed a commit that referenced this issue Aug 15, 2021
feat: update the expression markers when loading a pact file if overr…
60a6243 
…idden #1410
@uglyog
Copy link
Member

uglyog commented Aug 15, 2021

I've added two system properties to change the markers of the expressions:

  • pact.expressions.start
  • pact.expressions.end

@uglyog
Copy link
Member

uglyog commented Aug 22, 2021

4.1.25 released

@JapuDCret JapuDCret mentioned this issue Aug 23, 2021
Closed
@uglyog uglyog closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uglyog @bawoodruff