Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ANTLR code using version 4.8 or later #1380

Closed
knutwannheden opened this issue Jun 11, 2021 · 6 comments
Closed

Regenerate ANTLR code using version 4.8 or later #1380

knutwannheden opened this issue Jun 11, 2021 · 6 comments

Comments

@knutwannheden
Copy link

I am running pact tests in the context of a Quarkus service and about 1 year ago Quarkus upgraded from ANTLR 4.7.2 to ANTLR 4.8 (meanwhile ANTLR 4.9.2 is available). Now when running my tests I see a warning like this logged:

ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8ANTLR Runtime version 4.7.2 used for parser compilation does not match the current runtime version 4.8ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8ANTLR Runtime version 4.7.2 used for parser compilation does not match the current runtime version 4.8

Since ANTLR 4.7.2 is already more than two years old I think it would be nice to upgrade to a newer version.

@uglyog
Copy link
Member

uglyog commented Jun 24, 2021

I've checked the release notes, and there are no changes for Java so I've upgraded to 4.9.2

@knutwannheden
Copy link
Author

I think the ANTLR generator would also have to be rerun, as the ANTLR version is generated as a constant somewhere.

@knutwannheden
Copy link
Author

I couldn't find it in the repo anywhere. So I take it the generator is automatically executed as part of the build, which is perfect.

@uglyog
Copy link
Member

uglyog commented Jun 27, 2021

I couldn't find it in the repo anywhere. So I take it the generator is automatically executed as part of the build, which is perfect.

Yes, it uses the Gradle plugin to generate the source

@uglyog
Copy link
Member

uglyog commented Jun 27, 2021

4.2.7 has been released

@knutwannheden
Copy link
Author

I have verified that this now works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants