-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to populate pactbroker.host property together with scheme #1300
Comments
uglyog
pushed a commit
that referenced
this issue
Feb 20, 2021
This should have been done years ago. I've deprecated the host, port and scheme attributes in favour of just providing a URL, which is what everyone would only need |
@uglyog , yes. thanks! |
4.1.18 released |
This was referenced Mar 15, 2021
Issue can be closed, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
In our project we would like to do not send any additional property for scheme of pact broker (http/https). Instead of that it would be nice to have possibility to populate pactboroker.host property together with host.
Currently if I pass scheme into host it fails due to host is invalid.
Can anyone do the improvement of @PactBroker annotation to have this enhancement?
Actual result: pactbroker.host=https://my-pact-broker.url fails because of having https scheme in host name. for pactbroker.host=my-pact-broker.url doesn't fail.
Expected result: do not fail when I pass pactbroker.host=https://my-pact-broker.url and override default pactbroker.scheme with the pasted one into host name.
Thanks in advance!
The text was updated successfully, but these errors were encountered: