Is "min": 0 needed in matchers generated by Consumer PactDSL? (GroovyDSL doesn't use it)

[tlinkowski]

Current status

Right now:

• PactDSL generates an extra "min": 0 entry on calls to each*Like methods (source)
• while GroovyDSL does no such thing (source)

Example:

• Pact DSL: new PactDslJsonBody().eachLike("values", stringType("example")) generates

   "$.values": {
     "matchers": [{"match": "type", "min": 0}],
     "combine": "AND"
   }
   "$.values[*]": {
     "matchers": [{"match": "type"}],
     "combine": "AND"
   }

• Groovy DSL: { values eachLike(string('example')) } generates

   "$.values": {
     "matchers": [{"match": "type"}],
     "combine": "AND"
   }
   "$.values[*]": {
     "matchers": [{"match": "type"}],
     "combine": "AND"
   }

Consequences

Apart from the obvious (and unintuitive) discrepancy between PactDSL and GroovyDSL, the main drawback is that Pact Broker does not render the content of such eachLikes when it renders them.

That is, instead of:

"values": [
  "example"
]

Pact broker renders:

"values": [
]

which makes the preview in Pact Broker very much useless 😞

Question

Can the following occurrences of matchMin(0) below be replaced with TypeMatcher.INSTANCE?

1. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonBody.java

   Line 740 in 57a8541

   matchers.addRule(base, matchMin(0));

2. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonBody.java

   Line 769 in 57a8541

   matchers.addRule(matcherKey(name, rootPath), matchMin(0));

3. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonBody.java

   Line 796 in 57a8541

   matchers.addRule(matcherKey(name, rootPath), matchMin(0));

4. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonBody.java

   Line 1082 in 57a8541

   matchers.addRule(matcherKey(name, rootPath), matchMin(0));

5. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonBody.java

   Line 1156 in 57a8541

   matchers.addRule(rootPath + "*", matchMin(0));

6. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

   Line 129 in 57a8541

   matchers.addRule(rootPath + appendArrayIndex(1), matchMin(0));

7. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

   Line 148 in 57a8541

   matchers.addRule(rootPath + appendArrayIndex(1), matchMin(0));

8. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

   Line 736 in 57a8541

   parent.matchers.addRule("", parent.matchMin(0));

9. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

   Line 754 in 57a8541

   parent.matchers.addRule("", parent.matchMin(0));

10. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

    Line 955 in 57a8541

    matchers.addRule(rootPath + appendArrayIndex(1), matchMin(0));

11. pact-jvm/consumer/src/main/java/au/com/dius/pact/consumer/dsl/PactDslJsonArray.java

    Line 1034 in 57a8541

    matchers.addRule(rootPath + appendArrayIndex(1), matchMin(0));

Would you accept a PR with such a change?

[uglyog]

PRs are always welcome, but in this case it was a small change so I just did it.

[uglyog]

4.1.17 has been released