Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktor dependency of consumer module doesn't exist publicly yet in version expected by pact #1094

Closed
Tristan971 opened this issue May 20, 2020 · 7 comments

Comments

@Tristan971
Copy link

Tristan971 commented May 20, 2020

Hello,

I just tried to move to 4.1.0 in a project and hit a dependency resolution failure

The following artifacts could not be resolved: io.ktor:ktor-server-netty:jar:1.3.2, io.ktor:ktor-network-tls-certificates:jar:1.3.2: 
Failure to find io.ktor:ktor-server-netty:jar:1.3.2 in <central proxy repo> ...

This happens because of https://github.com/DiUS/pact-jvm/blob/4_1_0/consumer/build.gradle#L13

The io.ktor dependencies reference 1.3.2 but (as of right now), the latest version available on maven central is 1.3.1 according to:

I'm not exactly sure how this happened. I imagine the machine running the release job somehow got the dependency resolved through another repo where it had been published already?

Not sure what action could be taken ; I suppose something along the lines of ensuring that the build happens on a CI without any other repository but central?

Best regards

@Tristan971 Tristan971 changed the title Ktor dependency of consumer module doesn't exist publicly yet Ktor dependency of consumer module doesn't exist publicly yet in version expected by pact May 20, 2020
@uglyog
Copy link
Member

uglyog commented May 21, 2020

The KTor github page has 1.3.2 as the latest, and looking at their bintray repo it was published on 12 Mar 2020. I guess they have sync issues with Maven Central.

You can just enable bintray jcenter in your project, and that should resolve the dependency.

@Tristan971
Copy link
Author

Tristan971 commented May 21, 2020

Would not be willing to add other repositories (like bintray) to our main proxy repo, and even less so as part of every single pact-using application's pom/gradle file.

Don't think it's worth going into the pros and cons of central vs others here in general.

In the end, it's a matter of policy ; and if pact-jvm's is that dependencies do not necessarily need to be on maven central, then that's that.

I'll just wait for it to be eventually synced then.

@uglyog
Copy link
Member

uglyog commented May 24, 2020

@Tristan971 you misunderstood what I meant. I was just recommending as a short term fix. Either that or exclude that version until either the JAR is available on Maven central or the next version is released.

@Tristan971
Copy link
Author

Reassuring to read that then :-)

Will check again in a few days

uglyog pushed a commit that referenced this issue Jun 11, 2020
@anto-ac anto-ac closed this as completed Jun 20, 2020
@nikitsenka
Copy link

Any updates on it? Still see thee issue

@Tristan971
Copy link
Author

Tristan971 commented Dec 14, 2020

In @uglyog's commit of Jun 12 this was downgraded to ktor 1.3.1 which is on maven central (and still is 1.3.1 on master atm) ; we're having no issues here with it 😕

got some output logs to share?

@uglyog
Copy link
Member

uglyog commented Dec 27, 2020

Use the latest version, it has ktor 1.3.1 as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants