Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing license #1073

Closed
michaelbull opened this issue Apr 18, 2020 · 2 comments
Closed

Missing license #1073

michaelbull opened this issue Apr 18, 2020 · 2 comments

Comments

@michaelbull
Copy link

michaelbull commented Apr 18, 2020 •
edited
Loading

Hi, I have noticed you are redistributing my kotlin-result library in your core package. This is great and I'm thankful for your use of my library.

The classes include a comment which links back to my repository, which is appreciated, however you are missing the license file that must appear in all copies.

Please can you either depend on this library explicitly from a repository such as Maven Central (to avoid shipping the source yourselves) or include the license? Thanks in advance.
uglyog pushed a commit that referenced this issue Apr 19, 2020
chore: remove inlined kotlin-result in favour of version from Maven C…
d23697d 
…entral #1073
@uglyog
Copy link
Member

uglyog commented Apr 19, 2020

I have removed the in-lined version of your library.

@michaelbull
Copy link
Author

That's fantastic, thanks for the cooperation!

uglyog pushed a commit that referenced this issue Apr 29, 2020
chore: remove inlined kotlin-result in favour of version from Maven C…
d168fe5 
…entral #1073

(cherry picked from commit d23697d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uglyog @michaelbull