Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pact-jvm-consumer-junit README references nonexistent classes #1056

Closed
Thorn1089 opened this issue Mar 24, 2020 · 1 comment
Closed

pact-jvm-consumer-junit README references nonexistent classes #1056

Thorn1089 opened this issue Mar 24, 2020 · 1 comment

Comments

@Thorn1089
Copy link

The README appears to be out of date for the Pact JUnit 4 project. It references nonexistent classes ConsumerPactTestMk2 and PactProviderRuleMk2. These types are not found when I reference this library with Maven. I assume the correct types are the un-suffixed ConsumerPactTest and PactProviderRule.
@Thorn1089 Thorn1089 changed the title pact-jvm-consumer-junit references nonexistent classes pact-jvm-consumer-junit README references nonexistent classes Mar 24, 2020
@uglyog
Copy link
Member

uglyog commented Mar 28, 2020

Ah, yeah, those are the old 3.x classes.

uglyog pushed a commit that referenced this issue Mar 28, 2020
fix: correct the JUnit 4 readme to use the correct classes #1056
438e2f2
uglyog pushed a commit that referenced this issue Apr 29, 2020
fix: correct the JUnit 4 readme to use the correct classes #1056
fc518af 
(cherry picked from commit 438e2f2)
@anto-ac anto-ac closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uglyog @Thorn1089 @anto-ac