Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A TestTemplateInvocationContextProvider must not return an empty stream #1007

Closed
t1 opened this issue Jan 27, 2020 · 1 comment
Closed

A TestTemplateInvocationContextProvider must not return an empty stream #1007

t1 opened this issue Jan 27, 2020 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@t1
Copy link

t1 commented Jan 27, 2020

The javadoc of TestTemplateInvocationContextProvider# provideTestTemplateInvocationContexts says: This method is only called by the framework if #supportsTestTemplate previously returned true for the same ExtensionContext. Thus, this method must not return an empty Stream.

But the junit5 PactVerificationInvocationContextProvider returns an empty stream if it doesn't find any pacts. This results in the cryptic error message from JUnit 5: org.junit.platform.commons.PreconditionViolationException: No supporting TestTemplateInvocationContextProvider provided an invocation context

Can we throw an exception instead.

@uglyog uglyog added the bug Indicates an unexpected problem or unintended behavior label Feb 9, 2020
@uglyog
Copy link
Member

uglyog commented Feb 22, 2020

4.0.6 has been released with this fix

@uglyog uglyog closed this as completed May 7, 2020
anto-ac pushed a commit to anto-ac/pact-jvm that referenced this issue Jun 19, 2020
anto-ac pushed a commit to anto-ac/pact-jvm that referenced this issue Jun 19, 2020
anto-ac added a commit that referenced this issue Jun 19, 2020
…y-with-dates

fix: backward compatibily with legacy date formats #1007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants