fix: JUnit 4 tests were not running as the junit-vintage-engine was n…

…ot on the test classpath
pact-foundation · Jan 17, 2023 · a8877b2 · a8877b2
1 parent 7935300
commit a8877b2
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/buildSrc/src/main/groovy/au.com.dius.pact.kotlin-common-conventions.gradle b/buildSrc/src/main/groovy/au.com.dius.pact.kotlin-common-conventions.gradle
@@ -57,6 +57,7 @@ dependencies {
         testImplementation 'ch.qos.logback:logback-core:1.4.4'
         testImplementation 'net.bytebuddy:byte-buddy:1.12.7'
         testImplementation 'com.github.tomakehurst:wiremock-jre8:2.34.0'
+        testImplementation 'org.junit.vintage:junit-vintage-engine:5.9.2'
     }
 
     // Align versions of all Kotlin components
@@ -74,7 +75,7 @@ testing {
         // Configure the built-in test suite
         test {
             // Use JUnit Jupiter test framework
-            useJUnitJupiter('5.9.0')
+            useJUnitJupiter('5.9.2')
         }
     }
 }

diff --git a/consumer/junit/build.gradle b/consumer/junit/build.gradle
@@ -31,8 +31,7 @@ dependencies {
   testImplementation 'ch.qos.logback:logback-core'
   testImplementation 'ch.qos.logback:logback-classic'
   testImplementation 'org.apache.commons:commons-collections4'
-
-  testImplementation 'org.apache.commons:commons-collections4'
+  testImplementation 'org.junit.vintage:junit-vintage-engine'
   testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.13.4.2'
   testImplementation('io.rest-assured:rest-assured:5.2.0') {
     exclude group: 'org.apache.groovy'

diff --git a/consumer/junit5/build.gradle b/consumer/junit5/build.gradle
@@ -7,7 +7,7 @@ group = 'au.com.dius.pact.consumer'
 
 dependencies {
   api project(":consumer")
-  api 'org.junit.jupiter:junit-jupiter-api:5.9.0'
+  api 'org.junit.jupiter:junit-jupiter-api:5.9.2'
 
   implementation 'org.slf4j:slf4j-api'
 

diff --git a/provider/junit/build.gradle b/provider/junit/build.gradle
@@ -25,6 +25,7 @@ dependencies {
     testImplementation 'com.github.tomakehurst:wiremock-jre8'
     testImplementation 'ch.qos.logback:logback-classic'
     testImplementation 'org.apache.commons:commons-collections4'
+    testImplementation 'org.junit.vintage:junit-vintage-engine'
 
     // Required for Java 9
     testImplementation 'javax.xml.bind:jaxb-api:2.3.0'

diff --git a/provider/junit5/build.gradle b/provider/junit5/build.gradle
@@ -10,7 +10,7 @@ dependencies {
   api project(':core:support')
   api project(':core:pactbroker')
   api project(':core:model')
-  api 'org.junit.jupiter:junit-jupiter-api:5.9.0'
+  api 'org.junit.jupiter:junit-jupiter-api:5.9.2'
 
   implementation 'org.slf4j:slf4j-api'
   implementation('io.pact.plugin.driver:core:0.2.1') {