feat: force standalone="yes" when standalone is set to true on the XM…

…L builder #1414
pact-foundation · Sep 4, 2021 · 8ef8611 · 8ef8611
1 parent 3c752cd
commit 8ef8611
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/consumer/src/main/kotlin/au/com/dius/pact/consumer/xml/PactXmlBuilder.kt b/consumer/src/main/kotlin/au/com/dius/pact/consumer/xml/PactXmlBuilder.kt
@@ -77,6 +77,10 @@ class PactXmlBuilder @JvmOverloads constructor (
   fun asBytes(charset: Charset? = null): ByteArray {
     val transformer = TransformerFactory.newInstance().newTransformer()
     transformer.setOutputProperty(OutputKeys.INDENT, "yes")
+    if (standalone) {
+      transformer.setOutputProperty(OutputKeys.STANDALONE, "yes")
+    }
+
     val source = DOMSource(doc)
     val outputStream = ByteArrayOutputStream()
     val result = if (charset != null) {

diff --git a/consumer/src/test/groovy/au/com/dius/pact/consumer/xml/PactXmlBuilderSpec.groovy b/consumer/src/test/groovy/au/com/dius/pact/consumer/xml/PactXmlBuilderSpec.groovy
@@ -134,7 +134,7 @@ class PactXmlBuilderSpec extends Specification {
     where:
 
     standalone | value
-    true       | '<?xml version="1.0" encoding="UTF-8"?>'
+    true       | '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>'
     false      | '<?xml version="1.0" encoding="UTF-8" standalone="no"?>'
   }
 }