fix: handle exeptions from JUnit 4 state change methods

pact-foundation · May 27, 2020 · 1d20be8 · 1d20be8
1 parent 08ef85a
commit 1d20be8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/provider/junit/src/main/kotlin/au/com/dius/pact/provider/junit/InteractionRunner.kt b/provider/junit/src/main/kotlin/au/com/dius/pact/provider/junit/InteractionRunner.kt
@@ -157,6 +157,7 @@ open class InteractionRunner<I>(
       } catch (e: Throwable) {
         if (!pending) {
           notifier.fireTestFailure(Failure(description, e))
+          notifier.fireTestFinished(description)
         }
         testResult = VerificationResult.Failed(listOf(mapOf("message" to "Request to provider failed with an exception",
           "exception" to e)),

diff --git a/provider/junit/src/main/kotlin/au/com/dius/pact/provider/junit/RunStateChanges.kt b/provider/junit/src/main/kotlin/au/com/dius/pact/provider/junit/RunStateChanges.kt
@@ -3,11 +3,17 @@ package au.com.dius.pact.provider.junit
 import au.com.dius.pact.core.model.ProviderState
 import au.com.dius.pact.provider.junitsupport.State
 import au.com.dius.pact.provider.junitsupport.StateChangeAction
+import mu.KLogging
 import org.junit.runners.model.FrameworkMethod
 import org.junit.runners.model.Statement
 import java.util.function.Supplier
 import kotlin.reflect.full.isSubclassOf
 
+data class StateChangeCallbackFailed(
+  override val message: String,
+  override val cause: Throwable
+) : Exception(message, cause)
+
 class RunStateChanges(
   private val next: Statement,
   private val methods: List<Pair<FrameworkMethod, State>>,
@@ -31,10 +37,15 @@ class RunStateChanges(
         val target = stateChangeHandlers.map(Supplier<out Any>::get).find {
           it::class.isSubclassOf(method.first.declaringClass.kotlin)
         }
-        val stateChangeValue = if (method.first.method.parameterCount == 1) {
-          method.first.invokeExplosively(target, providerState.params)
-        } else {
-          method.first.invokeExplosively(target)
+        val stateChangeValue = try {
+          if (method.first.method.parameterCount == 1) {
+            method.first.invokeExplosively(target, providerState.params)
+          } else {
+            method.first.invokeExplosively(target)
+          }
+        } catch (e: Throwable) {
+          logger.error(e) { "State change method for \"${providerState.name}\" failed" }
+          throw StateChangeCallbackFailed("State change method for \"${providerState.name}\" failed", e)
         }
 
         if (stateChangeValue is Map<*, *>) {
@@ -43,4 +54,6 @@ class RunStateChanges(
       }
     }
   }
+
+  companion object : KLogging()
 }