fix merging message pacts - old messages taking precedence

pact-foundation · Feb 24, 2023 · 0da32ec · 0da32ec
1 parent 97aa673
commit 0da32ec
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/core/model/src/main/kotlin/au/com/dius/pact/core/model/messaging/MessagePact.kt b/core/model/src/main/kotlin/au/com/dius/pact/core/model/messaging/MessagePact.kt
@@ -70,7 +70,7 @@ class MessagePact @JvmOverloads constructor (
 
   override fun mergeInteractions(interactions: List<Interaction>): Pact {
     interactions as List<Message>
-    messages = (messages + interactions).distinctBy { it.uniqueKey() }.toMutableList()
+    messages = (interactions + messages).distinctBy { it.uniqueKey() }.toMutableList()
     sortInteractions()
     return this
   }

diff --git a/core/model/src/test/groovy/au/com/dius/pact/core/model/messaging/MessagePactSpec.groovy b/core/model/src/test/groovy/au/com/dius/pact/core/model/messaging/MessagePactSpec.groovy
@@ -85,4 +85,31 @@ class MessagePactSpec extends Specification {
     pact2 = new MessagePact(provider, consumer, [ message, message2 ])
   }
 
+  def 'merge message pact'() {
+    when:
+    pact.mergeInteractions(pact2.interactions)
+
+    then:
+    pact.interactions == [ newMessage1, message2 ]
+
+    where:
+    newMessage1 = new Message('message', [], OptionalBody.body('0 9 8 7'.bytes))
+    message2 = new Message('message2', [], OptionalBody.body('A B C'.bytes))
+    pact = new MessagePact(provider, consumer, [ message ])
+    pact2 = new MessagePact(provider, consumer, [ newMessage1, message2 ])
+  }
+
+
+  def 'merge message pact - same'() {
+    when:
+    pact.mergeInteractions(pact2.interactions)
+
+    then:
+    pact.interactions == [ message ]
+
+    where:
+    pact = new MessagePact(provider, consumer, [ message ])
+    pact2 = new MessagePact(provider, consumer, [ message ])
+  }
+
 }