chore: make artifact signing disabled for non-release builds #1291

pact-foundation · Aug 15, 2021 · 04a1e29 · 04a1e29 · kflorence · Aug 21, 2021
1 parent 8a27dcb
commit 04a1e29
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/build.gradle b/build.gradle
@@ -189,10 +189,9 @@ subprojects {
     }
   }
 
-  if (System.env.CI != 'true') {
-    signing {
-      sign publishing.publications.mavenPublication
-    }
+  signing {
+    required { project.hasProperty('isRelease') }
+    sign publishing.publications.mavenPublication
   }
 
   codenarc {

diff --git a/pact-jvm-server/build.gradle b/pact-jvm-server/build.gradle
@@ -82,8 +82,7 @@ publishing {
   }
 }
 
-if (System.env.TRAVIS != 'true') {
-  signing {
-    sign publishing.publications.serverDistribution
-  }
+signing {
+  required { project.hasProperty('isRelease') }
+  sign publishing.publications.serverDistribution
 }
diff --git a/releasePrep.groovy b/releasePrep.groovy
@@ -113,7 +113,7 @@ ask('Tag and Push commits?: [Y]') {
 }
 
 ask('Publish artifacts to maven central?: [Y]') {
-  executeOnShell './gradlew clean publish :provider:gradle:publishPlugins -S -x :pact-publish:uploadArchives'
+  executeOnShell './gradlew clean publish :provider:gradle:publishPlugins -S -x :pact-publish:uploadArchives -PisRelease=true'
 }
 
 ask('Publish pacts to pact-foundation.pact.dius.com.au?: [Y]') {