Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursively delete dir after session close #25

Merged
merged 1 commit into from
Feb 20, 2024
Merged

recursively delete dir after session close #25

merged 1 commit into from
Feb 20, 2024

Conversation

xgp
Copy link
Member

@xgp xgp commented Feb 20, 2024

  • add some static attributes (for future use to clean up naming)
  • recursively delete attribute theme tmp dir on provider close() method

@xgp xgp merged commit 0de4377 into main Feb 20, 2024
pnzrr pushed a commit that referenced this pull request Feb 22, 2024
@xgp @pnzrr
recursively delete dir after session close (#25)
bbc7921
@pnzrr
Copy link
Contributor

pnzrr commented Feb 22, 2024

@xgp I was noticing that tests were failing in reference to some of these variables. Might just be me

@xgp xgp mentioned this pull request Feb 26, 2024
Closed
@xgp
Copy link
Member Author

xgp commented Feb 27, 2024

@pnzrr Good catch. This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgp @pnzrr