feat: introduce mode config option #9818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce new config option to assert in which mode the UI should be rendered. There are two ways to set the mode, either by adding it into the
options
object in the config or viamode
query param. The config option takes precedence when both are defined. To showcase the functionality of the config, hide elements in the embed mode in the top bar component.Related Issue
Motivation and Context
This is needed to have functioning embed mode. Providing both config and query approaches makes us future proof. Same applies to having the option as
mode?: string
instead of e.g.embedded?: boolean
so that any other mode could be introduced in the future...How Has This Been Tested?
test case 2: set- does not work because of custom config not working (but unit tests are passing)options.mode
toembed
in config.jsonScreenshots (if appropriate):
Types of changes
Checklist: