Postprocessing state via SSE #9771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
Oct 11, 2023
dschmidt
reviewed
Oct 11, 2023
dschmidt
reviewed
Oct 12, 2023
changelog/unreleased/enhancement-handle-postprocessing-state-via-sse
Outdated
Show resolved
Hide resolved
| @@ -156,6 +158,10 @@ export class UserManager extends OidcUserManager { | |||
| }) | |||
| this.initializeOwnCloudSdk(accessToken) | |||
|
|
|||
| if (this.store.getters.capabilities?.core?.['support-sse']) { | |||
| ;(this.clientService.sseAuthenticated as SSEAdapter).updateAccessToken(accessToken) | |||
There was a problem hiding this comment.
I still don't like this too much, but we tried to refactor it and it got complicated ... I'm ok as it seems to be the lesser evil for now
There was a problem hiding this comment.
Same here. I think we will need a tokenProvider and languageProvider in the client soon.
You too ! |
JammingBen
approved these changes
Oct 13, 2023
AlexAndBear
force-pushed
the
sse-client
branch
from
5d9a66c to
0fedbac
Compare
AlexAndBear
force-pushed
the
sse-client
branch
from
0fedbac to
e7c35f6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
12 tasks
AlexAndBear
added a commit
that referenced
this pull request
Dec 13, 2023
rewrite SSEClient and implement postprocessing-finished event management --------- Co-authored-by: Paul Neubauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For testing please add this to your config:
Otherwise the postprocessing will be done before the webdav request announces the resource with processing=false
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: