Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] Addressing issue 3062 #3064

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Feb 19, 2020

Description

Fix confusing error message step wordings

Related Issue

Fixes issue #3062

Motivation and Context

The steps looked similar so it was difficult to decide which step to use in certain scenario.

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Talank Talank force-pushed the fixSimilarStepsForErrMsgCheck branch from 0b4a94b to fad5b4c Compare February 19, 2020 08:38
@Talank Talank force-pushed the fixSimilarStepsForErrMsgCheck branch from fad5b4c to fcd7f71 Compare February 19, 2020 09:41
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants