Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different description in overwrite dialog when versioning is enabled #3050

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Different description in overwrite dialog when versioning is enabled #3050

merged 1 commit into from
Feb 21, 2020

Conversation

LukasHirt
Copy link
Collaborator

Description

If versioning is enabled, display "Do you want to create new version?" message.

Related Issue

How Has This Been Tested?

  • test environment: Drone

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Category:Enhancement Add new functionality Status:Needs-Review Needs review from a maintainer labels Feb 17, 2020
@LukasHirt LukasHirt requested a review from PVince81 February 17, 2020 13:09
@LukasHirt LukasHirt self-assigned this Feb 17, 2020
@LukasHirt LukasHirt force-pushed the feature/different-messages branch from c9ad531 to 0bc01e8 Compare February 17, 2020 13:10
@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Feb 17, 2020 •
edited
Loading

The wording might be improved. E.g. instead of "want" "wish" but that would require touching also the message for overwrite so I think it should be addressed separately as part of #2994.

@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Feb 17, 2020 •
edited
Loading

But file "lorem (2).txt" should not be listed on the webUI - expected "visible" but got: "not visible"

Something is strange here...

butonic
butonic reviewed Feb 18, 2020
View reviewed changes
apps/files/src/mixins.js Outdated Show resolved Hide resolved
butonic
butonic reviewed Feb 18, 2020
View reviewed changes
apps/files/src/mixins.js Outdated Show resolved Hide resolved
butonic
butonic reviewed Feb 18, 2020
View reviewed changes
changelog/unreleased/3047 Outdated Show resolved Hide resolved
@LukasHirt
Copy link
Collaborator Author

Agh, now I understand the error. Since I put there the check for versions which is not last, on smaller screens it covers the whole files list 🤦‍♂

@LukasHirt LukasHirt force-pushed the feature/different-messages branch from 0bc01e8 to 3ac2eb4 Compare February 18, 2020 09:11
PVince81
PVince81 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit bcba338 into master Feb 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/different-messages branch February 21, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic left review comments

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overwrite dialog wording
3 participants
@LukasHirt @PVince81 @butonic