Separated navigation

[LukasHirt]

Description

In the sidebar is now only extension-specific navigation and into the apps switcher are automatically injected extensions which have at least one nav item. In the case that extension has only one nav item, the menu button is replaced by the name of the extension.

Related Issue

• Fixes Extension points app navigation vs app switcher #2746

How Has This Been Tested?

• test environment: Manually

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[LukasHirt]

I have a small issue when displaying some title for the current extension. Currently, it is displayed only in case of extension having only one nav item when it replaces the menu button. But when we have the menu button there it doesn't look nice. I'm thinking if this might be solved with having the sidebar always visible as was once already discussed. Then this issue would be solved. I'm just a bit scared of how it would look like when switching between extension with menu and without. Suddenly appearing sidebar might not be so nice in the end as well.

Anyway, seems to me like a problem for a separate issue.

[PVince81]

Looks fine so far, see comments

[PVince81]

I guess not easy to add acceptance tests ?

Regarding the trouble with the sidebar button: in what scenario would the button/sidebar flicker ? Is it when switching between an app that has a sidebar to one that doesn't ?

[LukasHirt]

I guess not easy to add acceptance tests ?

We'd need to load some other extension with routes to test the app switcher. And TBH I didn't want to implement acceptance tests for this part because I think this should be covered with unit tests. As soon as they're set up in Phoenix they can be implemented. I raised an issue for it here #3020

[LukasHirt]

Regarding the trouble with the sidebar button: in what scenario would the button/sidebar flicker ? Is it when switching between an app that has a sidebar to one that doesn't ?

Exactly. Basically scenario when an extension has only one nav item.

[kulmann]

Getting the currentExtensionName from an app that is only defined in applications (see config.json.sample) doesn't work. When I click on the app, the menu with burger icon stays and the js console throws an error. See comment for details.

[LukasHirt]

@kulmann Changes implemented or addressed.

[kulmann]

🚀