Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust labels in "new" menu in files app #2905

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

PVince81
Copy link
Contributor

Description

Replace "Create new" with "New" as it makes it look less cluttered when
trying to spot a matching entry.

Added changelog entry for this one and also another column header
change.

Related Issue

None raised, quick fix.

Motivation and Context

See description

How Has This Been Tested?

Manual test, see screenshot

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PVince81 PVince81 self-assigned this Jan 22, 2020
Replace "Create new" with "New" as it makes it look less cluttered when
trying to spot a matching entry.

Added changelog entry for this one and also another column header
change.
@PVince81 PVince81 force-pushed the adjust-newmenu-labels branch from a8acb11 to 0a1b66e Compare January 22, 2020 11:25
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is still doubled, as you have "+ New" on the button, but it's better than before. Current UI would just say "Folder" which I like better. Others have two buttons, one for Upload, one for Create and the entries are "Folder", "Word Document", etc..

@PVince81 PVince81 merged commit f9655ec into master Jan 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-newmenu-labels branch January 23, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants