Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock owner in file details #11859

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: lock owner in file details #11859

merged 2 commits into from
Nov 6, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 6, 2024

Description

We were showing () for for the Locked by field in the file details for two reasons:

  1. the lock owner propfind info was referencing the wrong field name
  2. the () were shown if there was no lock time

Fixing this by

  1. Referencing the correct field (after the backend prettified the string in that field)
  2. Showing (<lockTime>) only if there is a lockTime and hiding the parentheses entirely if there is no lockTime info

Related Issue

Screenshots (if appropriate):

Screenshot 2024-11-06 at 10 09 18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@kulmann kulmann self-assigned this Nov 6, 2024
Copy link

sonarcloud bot commented Nov 6, 2024

@kulmann kulmann enabled auto-merge November 6, 2024 10:04
@kulmann kulmann merged commit 346296b into master Nov 6, 2024
3 checks passed
@kulmann kulmann deleted the fix-show-lock-info branch November 6, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock information coming from collaboration service is shown empty
3 participants