Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a tag in context menu instead of button for editors in ctx menu #11854

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Nov 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann November 5, 2024 20:07
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog item, as this bug was part of a release.

@AlexAndBear AlexAndBear requested a review from kulmann November 5, 2024 20:11
@AlexAndBear
Copy link
Contributor Author

please add a changelog item, as this bug was part of a release.

Please have a little patience with old ppl like me :(

@AlexAndBear
Copy link
Contributor Author

Let's see if the e2e test are happy, they might check for button and not for a tag

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix! 🏎️

@AlexAndBear AlexAndBear enabled auto-merge (squash) November 5, 2024 20:18
Copy link

sonarcloud bot commented Nov 5, 2024

@AlexAndBear AlexAndBear merged commit acb2f24 into master Nov 5, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the issues/11853 branch November 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context-menu "Open in new tab" is broken
2 participants