Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create file from template #11775

Merged
merged 8 commits into from
Oct 17, 2024
Merged

feat: create file from template #11775

merged 8 commits into from
Oct 17, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Oct 15, 2024

Description

Adding a new file action for creating documents from templates via app provider (hence placing the action in the external app).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • re-prioritize file actions: create from template needs to be first action (on left click and in right-click context menu)
  • Closing the created document needs to navigate to the personal space root, not to the location of the template file
  • Changelog
  • Error handling during handler execution
  • Test coverage

Copy link

update-docs bot commented Oct 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the create-from-template branch 3 times, most recently from 65ca63b to ec8c946 Compare October 16, 2024 11:51
@kulmann kulmann requested a review from JammingBen October 17, 2024 09:28
@kulmann kulmann marked this pull request as ready for review October 17, 2024 09:28
@kulmann kulmann force-pushed the create-from-template branch from 35af9cd to 391e2a3 Compare October 17, 2024 10:17
@JammingBen
Copy link
Contributor

One bug that we found: when opening a template file in a project space while having the sidebar open, the shares panel still shows the project space members, despite the new file being in the personal space. This happens because the ancestors and therefore the loaded space members don't get cleared. This is a general problem with the app wrapper.

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks, rest is awesome!

Copy link

sonarcloud bot commented Oct 17, 2024

@kulmann kulmann merged commit 29e79ae into master Oct 17, 2024
3 checks passed
@kulmann kulmann deleted the create-from-template branch October 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Tests
Development

Successfully merging this pull request may close these issues.

Support Only Office template files
3 participants