feat: redesign link sharing panel in right sidebar #11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
feat/redesign-link-share-section
branch
10 times, most recently
from
7e5ad7a to
b2c9a1e
Compare
|
nice! could you add more spacing to the icons? already fulfilled https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html but its more convenient to have more space. |
JammingBen
force-pushed
the
feat/redesign-link-share-section
branch
from
3551ca2 to
68eebe9
Compare
7 tasks
tbsbdr
previously requested changes
Sep 23, 2024
8 tasks
added 3 commits
September 24, 2024 12:56
Aligns the design of the link sharing section with the people sharing section. Also refactors the code so both sections use the same structure (`LinkShares` > `ListItem` > `EditDropdown`).
JammingBen
force-pushed
the
feat/redesign-link-share-section
branch
from
68eebe9 to
ca199ad
Compare
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns the design of the link sharing section with the people sharing section. Also refactors the code so both sections use the same structure (
LinkShares>ListItem>EditDropdown).Additionally, moves the permanent link to the top right of the sharing panel.
Related Issue
Types of changes