Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logout when token renewal fails #11526

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Adds a logout when the token renewal fails for some reason. This fixes the issue with the user being able to access the Web UI without a valid token, leading to a broken state.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Sep 5, 2024
Copy link

update-docs bot commented Sep 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the fix/user-logout-on-token-renewal-failure branch from 7559e14 to 447a4c5 Compare September 5, 2024 12:46
@JammingBen JammingBen marked this pull request as ready for review September 5, 2024 13:03
@JammingBen JammingBen requested a review from kulmann September 5, 2024 13:03
Adds a logout when the token renewal fails for some reason. This fixes the issue with the user being able to access the Web UI without a valid token, leading to a broken state.
@JammingBen JammingBen force-pushed the fix/user-logout-on-token-renewal-failure branch from 447a4c5 to e20b1c9 Compare September 5, 2024 14:47
Copy link

sonarcloud bot commented Sep 5, 2024

@kulmann kulmann merged commit afff154 into master Sep 5, 2024
3 checks passed
@kulmann kulmann deleted the fix/user-logout-on-token-renewal-failure branch September 5, 2024 19:46
@micbar micbar mentioned this pull request Sep 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User does not get logged out when token renewal fails
2 participants