-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default actions extension point #11515
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
f3d6687
to
b5f7078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the scope of this, but what I noticed: shortcuts should probably be <a>
links too, no? At least for a11y reasons.
if (options.omitSystemActions) { | ||
return null | ||
} | ||
return unref(systemActions).filter(filterCallback)[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return unref(systemActions).filter(filterCallback)[0] | |
return unref(systemActions).find(filterCallback) |
Quality Gate passedIssues Measures |
* feat: introduce default actions extension point
It should be, but that would mean that we need to read and evaluate the .url files contents upon listing them, doesn't it? |
Description
This PR adds another extension point for the default actions of files (as used in resource table / tiles, etc). With this e.g. the new
Open in Notebooks
jupyter extension can be connected to the left click in the files list.Types of changes