Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default actions extension point #11515

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 4, 2024

Description

This PR adds another extension point for the default actions of files (as used in resource table / tiles, etc). With this e.g. the new Open in Notebooks jupyter extension can be connected to the left click in the files list.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Sep 4, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the default-actions-extension-point branch from f3d6687 to b5f7078 Compare September 4, 2024 13:34
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the scope of this, but what I noticed: shortcuts should probably be <a> links too, no? At least for a11y reasons.

if (options.omitSystemActions) {
return null
}
return unref(systemActions).filter(filterCallback)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return unref(systemActions).filter(filterCallback)[0]
return unref(systemActions).find(filterCallback)

@kulmann kulmann enabled auto-merge (squash) September 4, 2024 14:11
@kulmann kulmann disabled auto-merge September 4, 2024 14:11
Copy link

sonarcloud bot commented Sep 4, 2024

@kulmann kulmann merged commit 6dd15ac into master Sep 4, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Sep 4, 2024
* feat: introduce default actions extension point
@kulmann
Copy link
Member Author

kulmann commented Sep 5, 2024

Not for the scope of this, but what I noticed: shortcuts should probably be <a> links too, no? At least for a11y reasons.

It should be, but that would mean that we need to read and evaluate the .url files contents upon listing them, doesn't it?

@kulmann kulmann deleted the default-actions-extension-point branch September 5, 2024 19:45
@micbar micbar mentioned this pull request Sep 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants