Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v-calender replace with native browser input date field for expiryDates #11377

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Remove v-calender replace with native browser input date field for expiryDates #11377

merged 13 commits into from
Aug 22, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 19, 2024 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Aug 19, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Init Remove v-calender replace with native browser input date field for expiryDates Aug 20, 2024
JammingBen
JammingBen reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks, but I love it!

packages/web-app-files/src/components/Modals/DatePickerModal.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/components/CreateLinkModal.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/composables/piniaStores/modals.ts Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from JammingBen August 22, 2024 07:47
kulmann
kulmann reviewed Aug 22, 2024
View reviewed changes
packages/design-system/src/components/OcDatepicker/OcDatepicker.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/components/CreateLinkModal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
</template>
</oc-datepicker>
<div v-if="option.showDatepicker" class="oc-flex">
<oc-button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at least for screen readers we need a hint that using this button lets the user edit the expiration date. Debatable if we also need it for non-screen reader users. Maybe it's just simpler to use Edit expiration as button label instead of the current expiration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up

...iles/src/components/SideBar/Shares/Collaborators/InviteCollaborator/ExpirationDatepicker.vue
<span
v-else
key="set-expiration-date-label"
v-text="$gettext('Expires %{expires}', { expires: dateExpire })"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, Edit expiration might be the better label, although I like to see the expiration duration here :-(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up

@kulmann
Copy link
Member

kulmann commented Aug 22, 2024

Hope to see this merged soon, I'm super hyped about it! Awesome changes! 😍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 6cb9068 into master Aug 22, 2024
3 checks passed
@AlexAndBear AlexAndBear mentioned this pull request Aug 22, 2024
Merged
8 tasks
@kulmann kulmann deleted the date-picker branch September 5, 2024 19:47
@micbar micbar mentioned this pull request Sep 12, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y] Make entering dates accessible
3 participants
@AlexAndBear @kulmann @JammingBen