Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont load config routing from config.json, instead set based on cernFeatures option #11240

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Dont load config routing from config.json, instead set based on cernFeatures option #11240

merged 1 commit into from
Jul 22, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 19, 2024 •
edited
Loading

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Jul 19, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title option.routing.idBased and couple the feature it with cernFeatures option.routing and couple the feature it with cernFeatures Jul 19, 2024
@AlexAndBear AlexAndBear changed the title option.routing and couple the feature it with cernFeatures purge config option.routing and couple the feature it with cernFeatures Jul 19, 2024
@AlexAndBear AlexAndBear marked this pull request as ready for review July 19, 2024 12:09
@AlexAndBear AlexAndBear changed the title purge config option.routing and couple the feature it with cernFeatures Dont load config routing from config.json, instead set based on cernFeatures option Jul 19, 2024
@AlexAndBear AlexAndBear requested a review from dschmidt July 19, 2024 21:02
@AlexAndBear AlexAndBear enabled auto-merge (squash) July 22, 2024 09:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 7dc2731 into master Jul 22, 2024
3 checks passed
@kulmann kulmann deleted the issues/11216-2 branch September 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt dschmidt approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove config option option.routing
3 participants
@AlexAndBear @dschmidt @kulmann