Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trash bin breaking on parent folder navigation #11132

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Fixes an issue where the trash bin would break when navigating via the parent folder of a resource.

Also adds an interface for trashed resources to better distinguish them from regular resources.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jul 2, 2024
Fixes an issue where the trash bin would break when navigating via the parent folder of a resource.

Also adds an interface for trashed resources to better distinguish them from regular resources.
@JammingBen JammingBen force-pushed the fix/trash-bin-breaking branch from a1c809c to a9db667 Compare July 2, 2024 13:14
Copy link

sonarcloud bot commented Jul 2, 2024

@JammingBen JammingBen requested a review from AlexAndBear July 2, 2024 13:53
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice 🚀

@JammingBen JammingBen merged commit a94351d into master Jul 2, 2024
3 checks passed
@micbar micbar mentioned this pull request Jul 8, 2024
19 tasks
@kulmann kulmann deleted the fix/trash-bin-breaking branch September 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going back in browser history may break trash bin Add interface for deleted files
2 participants