Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable default autosave in editors #11093

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

JammingBen
Copy link
Contributor

Description

As per title.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen requested a review from kulmann June 24, 2024 15:05
@JammingBen JammingBen self-assigned this Jun 24, 2024
@kulmann
Copy link
Member

kulmann commented Jun 24, 2024

cherry pick to stable-8.0?

@JammingBen
Copy link
Contributor Author

cherry pick to stable-8.0?

Thought about it, it's a feature though... if we want to play by the rules 😂

Copy link

sonarcloud bot commented Jun 24, 2024

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jun 24, 2024

IHMO we should add an auto-save icon with a tooltip if this feature is enabled (as an indicator), anyways.

@kulmann
Copy link
Member

kulmann commented Jun 25, 2024

cherry pick to stable-8.0?

Thought about it, it's a feature though... if we want to play by the rules 😂

True 🙈 then let's play by the rules and don't add it to stable-8.0. 👍

@kulmann
Copy link
Member

kulmann commented Jun 25, 2024

IHMO we should add an auto-save icon with a tooltip if this feature is enabled (as an indicator), anyways.

Can you provide a mockup for this?

@AlexAndBear
Copy link
Contributor

IHMO we should add an auto-save icon with a tooltip if this feature is enabled (as an indicator), anyways.

Can you provide a mockup for this?

I don't have a high IQ in figma but putting a refresh-line remix icon with the tooltip next to the save button in the AppTopBar might help

I can fiddle around later and provide a screenshot if wished

@JammingBen
Copy link
Contributor Author

Alright, then I'm going to merge this as the spinner would be a separate task.

@JammingBen JammingBen merged commit 442495c into master Jun 25, 2024
3 checks passed
@micbar micbar mentioned this pull request Jul 8, 2024
19 tasks
@kulmann kulmann deleted the feat/default-autosave branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable "autosaveEnabled" per default
3 participants