Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tippy content iteractive to fix #5387 #11087

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Make tippy content iteractive to fix #5387 #11087

merged 2 commits into from
Jun 25, 2024

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter requested a review from kulmann June 24, 2024 09:10
@kulmann
Copy link
Member

kulmann commented Jun 24, 2024

We had interactive: true in the past but disabled it again for this reason:

web/packages/design-system/changelog/7.0.0_2021-05-31/bugfix-tippy-non-interactive

Line 3 in 94d5501

Interactive tooltips were breaking correct z-index behaviour so we set them to non-interactive.

Can you please check how it behaves nowadays?

@pascalwengerter
Copy link
Contributor Author

pascalwengerter commented Jun 24, 2024 •
edited
Loading

We had interactive: true in the past but disabled it again for this reason:

web/packages/design-system/changelog/7.0.0_2021-05-31/bugfix-tippy-non-interactive

Line 3 in 94d5501

Interactive tooltips were breaking correct z-index behaviour so we set them to non-interactive.

Can you please check how it behaves nowadays?

Somehow only breaks on the "shares" page 🤔

Screenshot 2024-06-24 at 12 53 54

but looks fine in the personal space?

Screenshot 2024-06-24 at 12 54 11

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kulmann
kulmann approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 4c15075 into owncloud:master Jun 25, 2024
3 checks passed
@JammingBen JammingBen mentioned this pull request Jul 3, 2024
Closed
@JammingBen
Copy link
Contributor

#11135 I guess these are the z-index issues :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y] 9.1.4.13 - Faded in content is operable
3 participants
@pascalwengerter @kulmann @JammingBen