Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endless initial loading spinner #11084

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Fixes an issue where the initial page loading spinner would not disappear in scenarios where we don't load all apps. This affects all plain layout pages such as the access-denied page, but also the password form for public links.

I'm not suuuuper happy with the solution, but I also can't find a better one currently.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jun 21, 2024
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this loading spinner be always in the DOM to enable it if needed on the fly?

If yes, it makes sense to adjust the comment wording since we actually don't remove it but hide/disable it.

If no, it makes sense to remove it from the dom

@JammingBen
Copy link
Contributor Author

Should this loading spinner be always in the DOM to enable it if needed on the fly?

Uhm yeah, it's always available in the DOM. I'll adjust the wording then.

@JammingBen JammingBen force-pushed the fix/endless-initial-loading-spinner branch from f833039 to f7c422c Compare June 24, 2024 08:58
Fixes an issue where the initial page loading spinner would not disappear in scenarios where we don't load all apps. This affects all plain layout pages such as the access-denied page, but also the password form for public links.
@JammingBen JammingBen force-pushed the fix/endless-initial-loading-spinner branch from f7c422c to 794c89c Compare June 24, 2024 08:59
@JammingBen JammingBen requested a review from AlexAndBear June 24, 2024 09:00
Copy link

sonarcloud bot commented Jun 24, 2024

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JammingBen JammingBen merged commit 644cff1 into master Jun 24, 2024
3 checks passed
@kulmann kulmann deleted the fix/endless-initial-loading-spinner branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial page loading spinner never hides in some scenarios
3 participants