Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSE for sharing #10807

Merged
merged 17 commits into from
Apr 25, 2024
Merged

SSE for sharing #10807

merged 17 commits into from
Apr 25, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 19, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Apr 19, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review April 25, 2024 07:51
dschmidt
dschmidt approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

packages/web-runtime/src/container/sse/helpers.ts Outdated Show resolved Hide resolved
JammingBen
JammingBen approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm obviously biased because I worked with you on this, but LGTM 👍

@AlexAndBear AlexAndBear enabled auto-merge (squash) April 25, 2024 07:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
13.8% Coverage on New Code
19.9% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 4f2f0e7 into master Apr 25, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sse-for-sharing branch April 25, 2024 08:28
@ScharfViktor ScharfViktor mentioned this pull request Apr 26, 2024
Closed
19 tasks
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt dschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Implement Events for Shares and Space Memberships (Indicator, Membership)
3 participants
@AlexAndBear @dschmidt @JammingBen