Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply sandbox attribute to draw-io iframe #10702

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: apply sandbox attribute to draw-io iframe #10702

merged 1 commit into from
Apr 3, 2024

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 3, 2024 •
edited
Loading

Description

Applying sandbox attribute to iframe in draw-io extension
https://www.w3schools.com/tags/att_iframe_sandbox.asp

Motivation and Context

👮

How Has This Been Tested?

  • ✋
  • open draw io file
  • see it still working properly

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Apr 3, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/drawio-iframe-sandbox branch from aac6f53 to 096764d Compare April 3, 2024 11:35
kulmann
kulmann reviewed Apr 3, 2024
View reviewed changes
changelog/unreleased/iframe-sandbox-drawio.md Outdated Show resolved Hide resolved
packages/web-app-draw-io/src/App.vue Outdated Show resolved Hide resolved
@pascalwengerter
Copy link
Contributor

@kulmann should this be added to the external app too? IIRC it uses iframes, too

@DeepDiver1975
Copy link
Member Author

@kulmann should this be added to the external app too? IIRC it uses iframes, too

I am working on this already ... kind of ....

@DeepDiver1975 DeepDiver1975 force-pushed the fix/drawio-iframe-sandbox branch from 096764d to c1f4ae6 Compare April 3, 2024 12:06
kulmann
kulmann approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 👮 likes this 💪

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann merged commit 567973f into master Apr 3, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/drawio-iframe-sandbox branch April 3, 2024 13:23
@pascalwengerter pascalwengerter mentioned this pull request Apr 9, 2024
Open
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @pascalwengerter @kulmann