Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details panel for unique trash and multi select #10624

Merged
merged 15 commits into from
Mar 18, 2024
Merged

Add details panel for unique trash and multi select #10624

merged 15 commits into from
Mar 18, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 15, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Mar 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Add details panel for unique trashed and multi select Add details panel for unique trashes and multi select Mar 15, 2024
@AlexAndBear AlexAndBear changed the title Add details panel for unique trashes and multi select Add details panel for unique trash and multi select Mar 15, 2024
@AlexAndBear
Build webdavUrl with space
6a6d8d5
@AlexAndBear
Fix types
00cb92b
@AlexAndBear
Fix rendering multiple (even wrong) panels after each other, because …
1c4258f 
…current folder is not updated propably and might be still there when navigation to trashbin or spaces
kulmann
kulmann requested changes Mar 18, 2024
View reviewed changes
packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/composables/extensions/useFileSideBars.ts Show resolved Hide resolved
packages/web-pkg/src/components/SideBar/FileSideBar.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/components/SideBar/WebDavDetails.vue
const resource = inject<Ref<Resource>>('resource')
const copiedIcon = 'check'
const copyIcon = 'file-copy'
const copyWebDAVPathIcon = ref(copyIcon)
const copyWebDAVUrlIcon = ref(copyIcon)

const webDavUrl = computed(() => {
return urlJoin(configStore.serverUrl, unref(resource).webDavPath)
return urlJoin(props.space.root.webDavUrl, unref(resource).path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 We should forward port current stable-8.0 right after this PR is merged, so that we still have in mind how to solve the merge conflict. :-)

packages/web-runtime/src/App.vue Show resolved Hide resolved
@AlexAndBear @kulmann
Update FileDetailsMultiple.vue
3c2f901 
Co-authored-by: Benedikt Kulmann <[email protected]>
kulmann
kulmann reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small scope creep requests:

  • could you make the text on the UserInfoBox panel in Admin Settings -> Users centered?
  • could you make the text on the GroupInfoBox panel in Admin Settings -> Groups centered?

@AlexAndBear
Copy link
Contributor Author

  • could you make the text on the UserInfoBox panel in Admin Settings -> Users centered?
  • could you make the text on the GroupInfoBox panel in Admin Settings -> Groups centered?

Which text exactly ? Its currently aligned with the other info boxes

@kulmann
Copy link
Member

kulmann commented Mar 18, 2024

Which text exactly ? Its currently aligned with the other info boxes

Screenshot 2024-03-18 at 11 45 02 Screenshot 2024-03-18 at 11 45 16

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
67.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear requested a review from kulmann March 18, 2024 11:24
JammingBen
JammingBen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

In the future we could introduce a new type for deleted files that extends the Resource interface and holds the ddate property. It would make checking for deleted resources really easy with some helper like isDeletedResource.

@AlexAndBear AlexAndBear merged commit 63767de into master Mar 18, 2024
3 checks passed
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
@kulmann kulmann deleted the issues/10620 branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show file/folder details in right sidebar inside trash Trashbin multi select is empty in right sidebar
3 participants
@AlexAndBear @kulmann @JammingBen