Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove left sidebar nav state from vuex store #10326

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

JammingBen
Copy link
Contributor

Description

No need to handle the state in a vuex store module, it can be simply handled within the Application component.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 12, 2024
Copy link

update-docs bot commented Jan 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jan 12, 2024
@JammingBen JammingBen requested a review from dschmidt January 12, 2024 10:48
@JammingBen JammingBen mentioned this pull request Jan 12, 2024
11 tasks
No need to handle the state in a vuex store module, it can be simply handled within the `Application` component.
@JammingBen JammingBen force-pushed the remove-navbar-vuex-state branch from bb0d8da to d826c96 Compare January 12, 2024 10:53
Copy link

sonarcloud bot commented Jan 12, 2024

@JammingBen JammingBen merged commit 1da6731 into master Jan 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-navbar-vuex-state branch January 15, 2024 09:12
@JammingBen JammingBen mentioned this pull request Jan 19, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants