Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences for not logged in users (public link context) #10207

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Preferences for not logged in users (public link context) #10207

merged 6 commits into from
Jan 15, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Dec 18, 2023 •
edited
Loading

Description

Enhancement: Enable user preferences in public links

We've enabled user preferences in public links, so any user even without an account can open
preferences in a public link context and for example change the current language.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Dec 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title WIP Preferences for not logged in users (public link context) Dec 19, 2023
@AlexAndBear AlexAndBear mentioned this pull request Dec 22, 2023
Closed
@AlexAndBear AlexAndBear force-pushed the enable-preferences-for-not-logged-in-users branch 3 times, most recently from 8b46a4d to 62d5ca0 Compare December 23, 2023 07:47
@AlexAndBear AlexAndBear force-pushed the enable-preferences-for-not-logged-in-users branch 2 times, most recently from 3326221 to ac4892d Compare January 15, 2024 13:04
@AlexAndBear AlexAndBear force-pushed the enable-preferences-for-not-logged-in-users branch from ac4892d to 210791e Compare January 15, 2024 13:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit 934b889 into master Jan 15, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enable-preferences-for-not-logged-in-users branch January 15, 2024 15:21
ownclouders pushed a commit that referenced this pull request Jan 15, 2024
@AlexAndBear
Preferences for not logged in users (public link context) (#10207)
0a9d734
@AlexAndBear AlexAndBear mentioned this pull request Jan 19, 2024
Closed
This was referenced Feb 22, 2024
Merged
Closed
saw-jan added a commit that referenced this pull request Mar 4, 2024
@saw-jan
test: port e2e test code from #10207
b7a4496
@saw-jan saw-jan mentioned this pull request Mar 4, 2024
Closed
saw-jan added a commit that referenced this pull request Mar 4, 2024
@saw-jan
test: port e2e test code from #10207
45a6ed6
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @lookacat @JammingBen