Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resource conflict modal #10205

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Dec 18, 2023

Description

Refactors the resource conflict modal to use a custom component. This allows us to remove the secondary action as well as the checkbox form the global modal as they were overly specific. The modal itself should be as slick as possible, anything custom like in this case should be handled by a custom component (or via a generic form builder).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 18, 2023
Copy link

update-docs bot commented Dec 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the refactor-resource-conflict-modal branch 3 times, most recently from 11507fe to bd21c05 Compare December 18, 2023 12:58
@JammingBen JammingBen marked this pull request as ready for review December 18, 2023 13:59
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uuuuh sweeeeet 🤩

@JammingBen JammingBen requested a review from kulmann December 18, 2023 18:23
@JammingBen JammingBen force-pushed the refactor-resource-conflict-modal branch from bd21c05 to 9f3f5c9 Compare December 19, 2023 05:16
Refactors the resource conflict modal to use a custom component. This allows us to remove the secondary action as well as the checkbox form the global modal as they were overly specific. The modal itself should be as slick as possible, anything custom like in this case should be handled by a custom component.
@JammingBen JammingBen force-pushed the refactor-resource-conflict-modal branch from 9f3f5c9 to 923e5c5 Compare December 19, 2023 06:35
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

44.12% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen merged commit 13f07aa into stable-8.0 Dec 19, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-resource-conflict-modal branch December 19, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants