-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: user action modals #10180
refactor: user action modals #10180
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
76651a4
to
af57b9e
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 7 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
It can be another iteration, but I would like to get rid of the store actions triggering in the dialog components, I think the modal should handle that automatically based on promises returned from onCancel and onConfirm.
You mean |
yep, as I said - can be in another iteration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
Description
Move several modal action handlers from
Users.vue
into their own components where they belong. This a) cleans up the component nicely and b) prevents the logic from being spread all over the place.Affected actions:
useUserActionsCreateUser.ts
. It opens theCreateUserModal.vue
which holds all the logicEditLoginModal.vue
AddToGroupsModal.vue
RemoveFromGroupsModal.vue
Also adds unit test for all these things.
This PR is best reviewed by its individual commits.
Related Issue
Types of changes