Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandatory filtering implementation #10099

Merged
merged 15 commits into from
Dec 5, 2023
Merged

Mandatory filtering implementation #10099

merged 15 commits into from
Dec 5, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 30, 2023 •
edited
Loading

Description

Don't load users initially and requires active filters if config var WEB_OPTION_USER_LIST_REQUIRES_FILTERis set to true

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear
Copy link
Contributor Author

@kulmann I added the generic mark-element class, we talked about for the mark initialization element selector

dschmidt
dschmidt approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to tell, but looks good from afar.

just minor nitpicks

packages/web-app-admin-settings/src/views/Users.vue Outdated Show resolved Hide resolved
packages/web-app-admin-settings/src/views/Users.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear force-pushed the admin-settings-users-search-via-backend branch from 72777d4 to b16211f Compare December 1, 2023 18:45
@AlexAndBear AlexAndBear requested a review from dschmidt December 1, 2023 18:45
@ScharfViktor
Copy link
Contributor

@janackermann sorry I created commit to wrong branch. I wanted to commit to fix-quicklink-issues but it done already so I create new PR

kulmann
kulmann approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, love it! 🥇

@kulmann kulmann enabled auto-merge (squash) December 5, 2023 06:40
@AlexAndBear AlexAndBear force-pushed the admin-settings-users-search-via-backend branch from f77b0e4 to 3214d7c Compare December 5, 2023 08:55
@AlexAndBear
Copy link
Contributor Author

@janackermann sorry I created commit to wrong branch. I wanted to commit to fix-quicklink-issues but it done already so I create new PR

Don't worry I dropped the commit

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 63 Code Smells

67.2% 67.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kulmann kulmann merged commit 0fd6dc2 into master Dec 5, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-users-search-via-backend branch December 5, 2023 09:35
ownclouders pushed a commit that referenced this pull request Dec 5, 2023
@AlexAndBear @ScharfViktor
Mandatory filtering implementation (#10099)
f3efb70 
* Mandatory filtering in users list
* add test to create quick link in project space

---------

Co-authored-by: Viktor Scharf <[email protected]>
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear @ScharfViktor
Mandatory filtering implementation (#10099)
ddbdec9 
* Mandatory filtering in users list
* add test to create quick link in project space

---------

Co-authored-by: Viktor Scharf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

@lookacat lookacat Awaiting requested review from lookacat

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve user listing performance for large installations
4 participants
@AlexAndBear @ScharfViktor @dschmidt @kulmann