fix: toggling checkboxes via enter key

owncloud · Aug 1, 2024 · fb80b52 · fb80b52
1 parent 389a1c1
commit fb80b52
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/changelog/unreleased/bugfix-resource-table-keyboard-checkbox b/changelog/unreleased/bugfix-resource-table-keyboard-checkbox
@@ -0,0 +1,6 @@
+Bugfix: Toggling checkboxes via keyboard
+
+Toggling checkboxes via the keyboard enter key in the resources table has been fixed and does now work.
+
+https://github.com/owncloud/web/pull/11312
+https://github.com/owncloud/web/issues/10730
diff --git a/packages/web-pkg/src/components/FilesList/ResourceTable.vue b/packages/web-pkg/src/components/FilesList/ResourceTable.vue
@@ -44,7 +44,7 @@
           :label="allResourcesCheckboxLabel"
           :hide-label="true"
           :model-value="areAllResourcesSelected"
-          @update:model-value="toggleSelectionAll"
+          @click.stop.prevent="toggleSelectionAll"
         />
       </div>
     </template>
@@ -56,8 +56,7 @@
         size="large"
         :model-value="isResourceSelected(item)"
         :outline="isLatestSelectedItem(item)"
-        @update:model-value="setSelection($event, item)"
-        @click.stop="fileClicked([item, $event, true])"
+        @click.stop.prevent="toggleSelection(item.id)"
       />
     </template>
     <template #name="{ item }">
@@ -483,9 +482,10 @@ export default defineComponent({
     resourceType: {
       type: String as PropType<'file' | 'space'>,
       default: 'file'
-    } /**
+    },
+    /**
      * Determines if the table content should be loaded lazily.
-     */,
+     */
     lazy: {
       type: Boolean,
       default: true