Merge pull request #11096 from pascalwengerter/fix/5398

Remove aria-describedby for OcDrop
owncloud · Jun 25, 2024 · 51dc7c6 · 51dc7c6
2 parents 30d73b0 + 5b5e821
commit 51dc7c6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/changelog/unreleased/enhancement-accessibility-improvements b/changelog/unreleased/enhancement-accessibility-improvements
@@ -3,4 +3,6 @@ Enhancement: Accessibility improvements
 Across the board, we have implemented improvements in regards of accessibility for the web UI.
 
 https://github.com/owncloud/web/issues/5387
+https://github.com/owncloud/web/issues/5398
 https://github.com/owncloud/web/pull/11087
+https://github.com/owncloud/web/pull/11096
diff --git a/packages/design-system/src/components/OcDrop/OcDrop.vue b/packages/design-system/src/components/OcDrop/OcDrop.vue
@@ -174,9 +174,6 @@ export default defineComponent({
       theme: 'none',
       maxWidth: 416,
       offset: this.offset ?? 0,
-      aria: {
-        content: 'describedby'
-      },
       ...(!this.isNested && {
         onShow: (instance: ReferenceElement) => {
           this.$emit('showDrop')

diff --git a/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap b/packages/design-system/src/components/OcDrop/__snapshots__/OcDrop.spec.ts.snap
@@ -3,7 +3,6 @@
 exports[`OcDrop > tippy > renders tippy 1`] = `
 <div>
   <p
-    aria-describedby="tippy-10"
     aria-expanded="true"
     id="trigger"
   >
@@ -100,7 +99,6 @@ exports[`OcDrop > tippy > renders tippy 2`] = `
 exports[`OcDrop > tippy > renders tippy 3`] = `
 <div>
   <p
-    aria-describedby="tippy-10"
     aria-expanded="true"
     id="trigger"
   >