check for undefined reminder values

owncloud · Jul 7, 2015 · 3583d04 · 3583d04
1 parent 7c1bf1a
commit 3583d04
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/controller/helper.php b/controller/helper.php
@@ -85,9 +85,17 @@ public static function arrayForJSON($id, $vtodo, $user_timezone, $calendarId){
 		$reminder = $vtodo->VALARM;
 		if($reminder) {
 			try {
-
-				$reminderType = $reminder->TRIGGER['VALUE']->getValue();
-				$reminderAction = $reminder->ACTION->getValue();
+
+				if ($reminder->TRIGGER['VALUE']){
+					$reminderType = $reminder->TRIGGER['VALUE']->getValue();	
+				} else {
+					throw new \Exception('Reminder type not specified.');
+				}
+				if ($reminder->ACTION) {
+					$reminderAction = $reminder->ACTION->getValue();
+				} else {
+					throw new \Exception('Reminder action not specified.');	
+				}
 				$reminderDate = null;
 				$reminderDuration = null;