feat: add exif panel options to web config struct #9267
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
services/web/pkg/config/options.go
Outdated
| } | ||
|
|
||
| // SidebarShares are the options for the shares sidebar | ||
| type SidebarShares struct { | ||
| ShowAllOnLoad bool `json:"showAllOnLoad" yaml:"showAllOnLoad" env:"WEB_OPTION_SIDEBAR_SHARES_SHOW_ALL_ON_LOAD" desc:"Sets the list of the (link) shares list in the sidebar to be initially expanded. Default is a collapsed state, only showing the first three shares." introductionVersion:"pre5.0"` | ||
| } | ||
|
|
||
| type SidebarExif struct { | ||
| ShowLocation bool `json:"showLocation" yaml:"showLocation" env:"WEB_OPTION_SIDEBAR_EXIF_SHOW_LOCATION" desc:"Shows or hides the location data in the EXIF sidebar panel." introductionVersion:"6.0"` |
There was a problem hiding this comment.
How does Shows or hides... correspond to the values to be set and any default?
There was a problem hiding this comment.
I added the default and simplified the first part a bit. The value is a bool, I won't add details what true or false does because that's already reflected by the var name.
kulmann
force-pushed
the
web-config-sidebar-exif
branch
from
9f7009f to
b5c4f16
Compare
|
| } | ||
|
|
||
| // SidebarShares are the options for the shares sidebar | ||
| type SidebarShares struct { | ||
| ShowAllOnLoad bool `json:"showAllOnLoad" yaml:"showAllOnLoad" env:"WEB_OPTION_SIDEBAR_SHARES_SHOW_ALL_ON_LOAD" desc:"Sets the list of the (link) shares list in the sidebar to be initially expanded. Default is a collapsed state, only showing the first three shares." introductionVersion:"pre5.0"` | ||
| } | ||
|
|
||
| type SidebarExif struct { | ||
| ShowLocation bool `json:"showLocation" yaml:"showLocation" env:"WEB_OPTION_SIDEBAR_EXIF_SHOW_LOCATION" desc:"Shows the location data in the EXIF sidebar panel. Default is the location data being shown." introductionVersion:"6.0"` |
There was a problem hiding this comment.
| ShowLocation bool `json:"showLocation" yaml:"showLocation" env:"WEB_OPTION_SIDEBAR_EXIF_SHOW_LOCATION" desc:"Shows the location data in the EXIF sidebar panel. Default is the location data being shown." introductionVersion:"6.0"` | |
| ShowLocation bool `json:"showLocation" yaml:"showLocation" env:"WEB_OPTION_SIDEBAR_EXIF_SHOW_LOCATION" desc:"Shows the location data in the EXIF sidebar panel. Default is the location data being shown." introductionVersion:"7.0.0"` |
There was a problem hiding this comment.
@AlexAndBear didn't we remove the option in web again? Then we could close this PR.
There was a problem hiding this comment.
Correct, see: owncloud/web#11226
Description
There is (will be) a new config option in web for hiding the location in the new image info sidebar panel. Adding the option to the web config struct, so that we disabling the location actually works (vanishes from the exposed config.json otherwise).
Types of changes
Checklist: